fix(studio): break all 7 circular dependency cycles + fix rules-of-hooks violation#1422
Merged
Conversation
Fallow audit reportFound 26 findings. Dead code (3)
Duplication (8)
Health (15)
Generated by fallow. |
8afedab to
403daca
Compare
403daca to
24de1c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/studio/src/useMemoafter early return in App.tsx) that caused "Rendered more hooks than during the previous render" errorChanges
Rules-of-hooks fix: Moved
useMemofortimelineToolbarbefore the early return inApp.tsxso hook count is stable across renders.Circular dep fixes (14 files, net -10 LOC):
domEditCommitTypes.tsto break useDomEditCommits ↔ useDomEditPositionPatchCommit/useDomEditTextCommits cycles../player) to direct source imports to break player/index.ts cyclesCOMPOSITION_ROOT_REGEXtocompositionPatterns.tsto break studioHelpers ↔ timelineAssetDrop cycleVerification
npx madge --circular packages/studio/src/App.tsx→ 0 circular dependencies (was 7)bun run --cwd packages/studio typecheck→ passbun run --cwd packages/studio test→ 796 tests passTest plan
bun run --cwd packages/studio typecheckpassesbun run --cwd packages/studio testpasses